-
Notifications
You must be signed in to change notification settings - Fork 207
Support IPv6 Unique Local Addresses #1294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Marcus, that is quick, you also adapted the UT's. I checked the changes in your PR, the essence is the addition of a new packet type: Then I tested it by pinging two addresses: IP-address of my laptop: I am able to ping the Zynq. |
htibosch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Integration testing: it took me a while to realise that my laptop's antivirus is stopping packets to the new ULA address fd12:3456:789a::3.
I saw the packets arriving in Wireshark, but the ICMP/ping requests were ignored.
It looks all good to me, so I approve your PR.
Thanks,
|
I tested one more thing, using FileZilla to access a local drive, using an ULA and TCP. Remember that FileZilla expects IPv6 addresses between square brackets: |
3058111 to
d68e986
Compare
This change correctly identifies ULAs with the fc00::/7 prefix, so that they can be assigned to endpoints and correctly matched to received packets.
d68e986 to
fd74f08
Compare
Description
This change correctly identifies ULAs with the fc00::/7 prefix, so that they can be assigned to endpoints and correctly matched to received packets.
Test Steps
Configured the application with two IPv6 endpoints, one link-local and one ULA.
Ping the ULA address. Replies would be echoed back from the link-local address.
After fixing, both IPv6 addresses can be pinged, and replies come from the target address.
Checklist:
Related Issue
#1293
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.